fix for non-coherent cmis modules#2163
Merged
prgeor merged 4 commits intosonic-net:masterfrom May 26, 2022
Merged
Conversation
prgeor
requested changes
May 11, 2022
Contributor
prgeor
left a comment
prgeor
left a comment
There was a problem hiding this comment.
line 369 won't be hit for QSFP-DD because of the check at line 328
The else check at line 332 won't be hit non-CMIS module
Can you remove 'pass' in the else condition at line 348 and 353
prgeor
reviewed
May 23, 2022
sfputil/main.py
Outdated
| output += '{}{}: {}\n'.format((indent * 2), compliance_key, spec_compliance_dict[compliance_key]) | ||
| except ValueError as e: | ||
| output += '{}N/A\n'.format((indent * 2)) | ||
| elif key == 'application_advertisement': |
Contributor
There was a problem hiding this comment.
We are interested in this field, so why remove from output?
sfputil/main.py
Outdated
| output += '{}{}: {}\n'.format((indent * 2), compliance_key, spec_compliance_dict[compliance_key]) | ||
| except ValueError as e: | ||
| output += '{}N/A\n'.format((indent * 2)) | ||
| elif key == 'application_advertisement': |
Contributor
There was a problem hiding this comment.
We are interested in this field, so why remove from output?
prgeor
approved these changes
May 26, 2022
6 tasks
This was referenced Jun 9, 2022
Collaborator
yxieca
pushed a commit
that referenced
this pull request
Jul 28, 2022
* fix for non-coherent cmis modules * addressing comments * add back application_advertisement * fixing test failure Co-authored-by: Chuan Qin (QINCHUAN) <QINCHUAN@ame.gbl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on a QSFP-DD non-coherent Molex DR4 module. It won't crash.
admin@sonic:~$ sudo sfputil show eeprom -d -p Ethernet16
Ethernet16: SFP EEPROM detected
Active App Selection Host Lane 1: 1
Active App Selection Host Lane 2: 1
Active App Selection Host Lane 3: 1
Active App Selection Host Lane 4: 1
Active App Selection Host Lane 5: 1
Active App Selection Host Lane 6: 1
Active App Selection Host Lane 7: 1
Active App Selection Host Lane 8: 1
Active Firmware Version: 3.1
CMIS Revision: 4.0
Connector: MPO 1x12
Encoding: N/A
Extended Identifier: Power Class 6 (12.0W Max)
Extended RateSelect Compliance: N/A
Hardware Revision: 1.1
Host Electrical Interface: 400GAUI-8 C2M (Annex 120E)
Host Lane Assignment Options: 1
Host Lane Count: 8
Identifier: QSFP-DD Double Density 8X Pluggable Transceiver
Inactive Firmware Version: 3.1
Length Cable Assembly(m): 0.0
Media Interface Code: 400GBASE-DR4 (Cl 124)
Media Interface Technology: 1310 nm DFB
Media Lane Assignment Options: 1
Media Lane Count: 4
Nominal Bit Rate(100Mbs): 0
Specification compliance: sm_media_interface
Vendor Date Code(YYYY-MM-DD Lot): 2021-05-24
Vendor Name: MOLEX
Vendor OUI: 00-09-3a
Vendor PN: 1064281000
Vendor Rev: 11
Vendor SN: G21211B3113
ChannelMonitorValues:
RX1Power: -40.0dBm
RX2Power: -40.0dBm
RX3Power: -40.0dBm
RX4Power: -40.0dBm
RX5Power: -infdBm
RX6Power: -infdBm
RX7Power: -infdBm
RX8Power: -infdBm
TX1Bias: 166.36mA
TX1Power: 2.5193008503036833dBm
TX2Bias: 136.256mA
TX2Power: 3.029150795688614dBm
TX3Bias: 166.408mA
TX3Power: 2.9567703401746503dBm
TX4Bias: 168.056mA
TX4Power: 2.893213375714688dBm
TX5Bias: 0.0mA
TX5Power: -infdBm
TX6Bias: 0.0mA
TX6Power: -infdBm
TX7Bias: 0.0mA
TX7Power: -infdBm
TX8Bias: 0.0mA
TX8Power: -infdBm
ChannelThresholdValues:
RxPowerHighAlarm : 5.0dBm
RxPowerHighWarning: 4.5dBm
RxPowerLowAlarm : -8.901dBm
RxPowerLowWarning : -6.899dBm
TxBiasHighAlarm : 380.0mA
TxBiasHighWarning : 352.0mA
TxBiasLowAlarm : 32.0mA
TxBiasLowWarning : 40.0mA
TxPowerHighAlarm : 5.0dBm
TxPowerHighWarning: 4.5dBm
TxPowerLowAlarm : -3.401dBm
TxPowerLowWarning : -2.901dBm
ModuleMonitorValues:
Temperature: 45.465C
Vcc: 3.341Volts
ModuleThresholdValues:
TempHighAlarm : 75.0C
TempHighWarning: 72.0C
TempLowAlarm : -5.0C
TempLowWarning : -2.0C
VccHighAlarm : 3.51Volts
VccHighWarning : 3.495Volts
VccLowAlarm : 3.1Volts
VccLowWarning : 3.115Volts